Repository navigation
feat(config): add Qwen3.8 GB300 AgentX / feat(config): 新增 Qwen3.8 GB300 AgentX 配置 - #3816
Conversation
新增 Qwen3.8-Flash-Next NVFP4 的 GB300 AgentX 配置,使用原生 NEXTN MTP 和 SGLang HiCache。
|
Thanks for the contribution!
中文感谢你的贡献!
|
更新 Qwen3.8 GB300 changelog 条目的 PR 链接。
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. Because the two files it touches (inferencex-e2e/configs/nvidia-master.yaml and the new gb300-fp4-mtp/agentic.yaml recipe) are CODEOWNERS-protected and require sign-off from the listed NVIDIA maintainers, a human look would still be worthwhile.
What was reviewed:
- New agentic.yaml recipe:
identity.container.imageandmodel.containermatch; checked theenable-linear-replayssm-specwithoutlinear-replayssm-cache-lenconcern raised by earlier passes — several other existing recipes in the repo (e.g. the gb300-fp8 nightly agentx configs) also omit this companion flag, so it's not unique to this change. - Confirmed the missing
USE_CHAT_TEMPLATEenv var is expected here:validate_recipeininfx/srt_slurm/single_node.pyonly requires it for non-agentic recipes, and this one is agentic (srt_agentic.sh). nvidia-master.yaml's new search-space entry and theperf-changelog.yamlentry are consistent with the recipe and correctly appended at the tail.- The changelog's
pr-linkis still thepull/XXXplaceholder; per CONTRIBUTING.md that's filled in after the PR number is known, but it should be set to the real URL before merge.
Extended reasoning...
Config/recipe-only addition (new SGLang GB300 AgentX recipe for Qwen3.8-Flash-Next NVFP4, a master-config entry, and a perf-changelog block) with no source code touched, so no injection/auth/data-exposure surface. Verified the image/container pin matches, the agentic-only USE_CHAT_TEMPLATE exemption in validate_recipe, and that the flagged replayssm cache-len omission has precedent elsewhere in the repo. Both changed files fall under CODEOWNERS entries naming specific NVIDIA maintainers (including the PR author themselves), which is the deciding factor for deferring to a human review rather than approving.
This review covers commit c01e7c4, which is no longer the latest commit on this pull request; later commits are not covered by it.
|
View unofficial run (performance): https://inferencex.semianalysis.com/inference?unofficialRun=37714835620 View unofficial run (accuracy): https://inferencex.semianalysis.com/evaluation?unofficialRun=37714835620 |
|
/use 37714835620 |
|
@RohitNagraj staged run 37714835620: https://inferencemax-app-git-staging-semianalysisai.vercel.app/inference?i_dates=2026-10-08~r37714835620 This run remains available across future |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have:
Additional detail section:
Signed: |
✅✅✅ Verdict: PASS ✅✅✅Passed and not applicable checks✅ Check 0 (CODEOWNER): PASS — ✅ Check 1 (Passing sweep + evals on in-PR commit): PASS — head ✅ Check 2 (Eval accuracy): PASS — ✅ Check 3 (Upstream recipe): PASS — sgl-project/sglang#43159 is MERGED (2026-10-08T23:56:31Z, ✅ Check 4 (Reuse command): PASS — ✅ Check 5 (Latest checklist template): PASS — all 16 items in the current template, including the recipe sub-item, are present and checked. ✅ Check 6 (Upstream image / engine-first): PASS — ✅ Check 7 (No deprecated models/scenarios): PASS — MODELS.md lists ✅ Check 8 (No architecture hacks / event publication): PASS — no ✅ Check 9 (Spec-decode via chat template): PASS — the aiperf ✅ Check 10 (No engine patches): PASS — the stock image runs with no patch, ✅ Check 11 (Agentic golden AL): PASS — the c4 job log shows ➖ Check 12 (Append-only): N/A — the new changelog entry does not set ✅ Check 13 (Draft runs as shipped): PASS — the embedded MTP head comes from the same checkpoint revision ✅ Check 14 (Pareto coverage): PASS — one curve, ✅ Check 15 (PR description): PASS — the body's claims match the code and run: stock SGLang v0.5.21-cu130 with a pinned digest and revision, TP1/EP1 aggregate, NEXTN MTP, HiCache, concurrency 1–64, BF16 target/draft KV, metrics and cache reporting, golden AL for throughput and real verification for the eval. Assessed commit: |
functionstackx
left a comment
There was a problem hiding this comment.
can u add to cookbook , the new ponah way
|
[by Claude Code] The SGLang cookbook integration of this PR's AgentX config ( |
|
[by Claude Code] sgl-project/sglang#43083 has been merged. This PR's AgentX config ( The commands mirror the launch measured in run 37714835620, pinned by this PR's |
cquil11
left a comment
There was a problem hiding this comment.
Approved for merge with the existing CODEOWNER sign-off and sweep reuse. The cookbook update is merged in sgl-project/sglang#43083.
Add a GB300 AgentX configuration for Qwen3.8-Flash-Next NVFP4 using stock SGLang v0.5.21-cu130, aggregate TP1/EP1, native NEXTN MTP, and SGLang HiCache. Cover concurrency 1, 2, 4, 8, 16, 32, 48, and 64.
Pin the container digest and checkpoint revision, retain the checkpoint's embedded MTP head, and use BF16 target/draft KV. Enable engine metrics and cache reporting, with automatic golden acceptance for throughput and real verification for evaluation. Use the existing GB300 cluster profile and native Hugging Face checkpoint loading.
AI model disclosure
The runtime identifies the GPT-6 family; the exact model/version could not be verified. Role: configuration preparation, review, and local validation. No delegated agents contributed.
PR checklist and change type
Type of Change
Checklist
inferencex-e2e/perf-changelog.yamland have not edited historical entriesfull-sweep-fail-fast(recommended),full-sweep-enabled, ornon-canary-full-sweep-enabled. Optional modifiersall-evals,evals-only, andagentx-fastrequire a primary label; the last two block reuse.OWNER/MEMBER/COLLABORATOR) has commented/use <run_id>(or the legacy/reuse-sweep-run) on this PR. Do this only once there is a final full sweep that is all green with evals passing, since after this comment the primary sweep label will no longer automatically kick off new sweeps. Remove and re-add the primary sweep label to force a new sweep.中文
新增 Qwen3.8-Flash-Next NVFP4 的 GB300 AgentX 配置,使用原版 SGLang v0.5.21-cu130、聚合式 TP1/EP1、原生 NEXTN MTP 和 SGLang HiCache,覆盖并发数 1、2、4、8、16、32、48、64。
固定容器 digest 和 checkpoint 版本,保留 checkpoint 自带的 MTP head,并为 target 和 draft 使用 BF16 KV。启用引擎 metrics 和缓存报告;吞吐测试自动选择 golden acceptance,质量评测使用真实验证。使用现有 GB300 cluster profile 和原生 Hugging Face checkpoint 加载方式。
运行环境仅标识 GPT-6 系列,无法核实准确模型及版本。工作内容为配置准备、审查和本地验证;未使用委派 agent。改动类型为新增功能和配置变更,检查清单已在上方填写。